Code review should not act as a quality gate
In this Linkedin thread someone said that we should not merge poor-quality code, but wait for fixing problems in a merge request.
I slightly disagreed#
Well, I agree with some points.
Code review is important, I just disagree with code review as a quality gate. In my opinion, quality should be built into the development process, and to achieve that you should focus more on culture, way of working, improving collaboration, building trust with the team, the end user and most importantly - learning. Instead of detecting errors, we should shape our development process in a way that errors are almost not possible.
I’ve seen many examples in my career of crappy code being approved by many people, because those people didn’t know how to write good code and good tests. The pull-request approval process creates an illusion of quality. It looks good on paper and during audits, but it doesn’t solve the problem of lack of knowledge or inefficient processes, etc.